Feature/1897 psk #1961
Merged
Feature/1897 psk #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmiM
force-pushed
the
feature/1897-psk
branch
from
8ae801d to
294945c
Compare
siepra
reviewed
Oct 25, 2023
siepra
reviewed
Oct 25, 2023
There was a problem hiding this comment.
I see Android e2e tests have failed, can you make sure it's not because of the changes you made? https://github.com/TryQuiet/quiet/actions/runs/6632205761/job/18017378690?pr=1961
We had a similar situation with @Kacper-RF in some other PR and it turned out to actually be a problem with the code
…fore handling it to joincommunityscreen
…are not backward compatible
leblowl
suggested changes
Oct 30, 2023
packages/state-manager/src/sagas/communities/communities.selectors.ts
Outdated
Show resolved
Hide resolved
leblowl
suggested changes
Oct 30, 2023
packages/backend/src/nest/connections-manager/connections-manager.service.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/nest/connections-manager/connections-manager.service.ts
Outdated
Show resolved
Hide resolved
packages/state-manager/src/sagas/communities/createNetwork/createNetwork.saga.ts
Outdated
Show resolved
Hide resolved
packages/state-manager/src/sagas/identity/registerUsername/registerUsername.saga.ts
Outdated
Show resolved
Hide resolved
leblowl
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Awesome work! Thanks so much for doing this! I don't want to approve as a gatekeeper, but rather as a "+1", as a partner. There are a lot of different ways of doing things and there really isn't an ultimately right way, so it's important to keep our minds open to our creative inspiration.
packages/state-manager/src/sagas/communities/createNetwork/createNetwork.saga.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package:
Task related: