Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1976 - display a shorter invite link on a mobile #1983

Merged
merged 3 commits into from
Oct 20, 2023
Merged

bug/1976 - display a shorter invite link on a mobile #1983

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69e6f8a
feat:display a shorter invite link on a mobile
Kacper-RF Oct 19, 2023
6109b17
fix: use numberOfLines
Kacper-RF Oct 20, 2023
778d9a0
fix:add long invitation link to story for context menu
Kacper-RF Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* Shorter dots-placeholder for invite link

* Display a shorter invite link on a mobile

* Removed registration attempts selector and corresponding usage.

* Revert adjusting bootstrap scripts for developing on Windows
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/src/components/ContextMenu/menus/InvitationContextMenu.container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export const InvitationContextMenu: FC = () => {
title={'Add members'}
items={items}
hint={'Anyone with Quiet app can follow this link to join this community. Only share with people you trust.'}
link={invitationLink}
link={invitationLink.slice(0, 35) + '...'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we do it with css text-overflow: ellipsis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in React Native from what I can see, but I found an equivalent to this - numberOfLines={1}

linkAction={copyLink}
{...invitationContextMenu}
/>
Expand Down
Loading