Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/contributing.md #2003

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Chore/contributing.md #2003

merged 5 commits into from
Oct 25, 2023

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Oct 24, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@siepra siepra mentioned this pull request Oct 24, 2023
Closed
leblowl
leblowl approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One minor suggestion

CONTRIBUTING.md Outdated Show resolved Hide resolved
@siepra siepra merged commit d5c0914 into develop Oct 25, 2023
7 checks passed
@siepra siepra deleted the chore/CONTRIBUTING.md branch October 25, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siepra @leblowl