Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/Display "<user> has joined <community>" message when unregistered user joins[NEW] #2067

Merged
merged 19 commits into from
Nov 22, 2023
Merged

feature/Display "<user> has joined <community>" message when unregistered user joins[NEW] #2067

merged 19 commits into from
Nov 22, 2023

Conversation

Kacper-RF
Copy link
Contributor

@Kacper-RF Kacper-RF commented Nov 14, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@Kacper-RF Kacper-RF marked this pull request as ready for review November 16, 2023 11:20
@Kacper-RF Kacper-RF mentioned this pull request Nov 16, 2023
Closed
@Kacper-RF Kacper-RF requested review from EmiM and siepra November 20, 2023 10:27
siepra
siepra reviewed Nov 20, 2023
View reviewed changes
packages/common/src/messages.test.ts
describe('messages helper', () => {
const username = 'johnny'

const generalChannel: PublicChannelStorage = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you'd use factory-girl for mocking channel objects. It's minor though.

const generalChannel = (await factory.build<typeof publicChannels.actions.addChannel>('PublicChannel', {
      id: generateChannelId('general'),
      name: 'general',
      owner: username
    })).payload

siepra
siepra reviewed Nov 20, 2023
View reviewed changes
packages/state-manager/src/sagas/messages/verifyMessage/verifyMessages.saga.test.ts
it('verify standard message ', async () => {
if (!alice.userCsr?.userCsr) throw Error('no Alice userCsr')

const message: ChannelMessage = {
Copy link
Contributor

@siepra siepra Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why didn't you use factory-girl to mock message object as you did for users and channels? It covers signature for you

@Kacper-RF Kacper-RF merged commit 9e1a2f4 into develop Nov 22, 2023
13 of 16 checks passed
@siepra siepra deleted the 1836/user-joined-message branch December 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siepra siepra siepra approved these changes

@vinkabuki vinkabuki Awaiting requested review from vinkabuki

@EmiM EmiM Awaiting requested review from EmiM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kacper-RF @EmiM @siepra