Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/master to develop #2104

Merged
merged 25 commits into from
Nov 23, 2023
Merged

Chore/master to develop #2104

merged 25 commits into from
Nov 23, 2023

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Nov 22, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

EmiM and others added 19 commits October 9, 2023 21:49
…lhost i.e. browser (#1940)

* secure socket IO connection with token and origin, transform token from main.ts to backend and state manager

* add JWT

* not throw error on missing auth token

* send 401 to unauthorized user

* generate random secret

* use basic auth instead of JWT

* auth tests

* WIP: secure sockets mobile

* fix:lint

* Pass socketioSecret to backend

* Add authorization headers to socketio android notifications client

* Secure socketIO connection on iOS

* Use random string for securing socketIO pn iOS

* Extend lastKnownPort to lastKnownSocketIOData on android

* Handle socketIOSecret for iOS lifecycle event

* Code quality fixes

* Create Utils class on iOS and move relevant methods there

* feat: getRandomValues and concept for validating options on backend

* fix: generating secret

* feat: use IPC and Redux store for transfering socketIOSecret

* test: add socketIOSecret selector test

* test: add startConnectionSaga test

* Use secure random for socketio secret

* fix: use secure crypto for ios socketio secret

* fix: add Utils file to the project

* fix: check pkijs

* fix: revert changes with pkijs

* fix:change order

* fix: generate secret after setEngine

* fix: backwards test for prod versions

* fix: remove peculiar/webcrypto from common

* fix: file name

---------

Co-authored-by: Vin Kabuki <[email protected]>
Co-authored-by: siepra <[email protected]>
…2042)

* feat: notifier component #1980

* feat: notifier screen

* feat: navigation pop

* feat: bind pop to the notifier button #1980

* feat: attach notifier screen #1980

* fix: current screen selector

* fix: remove emojis from notifier message

* feat: use mailto for support address #1980

* chore: cleanup

* fix: building mobile package #1980

* fix: lint
fix: pass team id for notarization
* feat: make update modal configurable

* chore: add update modal story

* chore: pass buttons dynamically to the update modal component

* feat: show breaking changes warning on app start #2039

* fix: update modal component styling

* feat: redirect to downloads page on button click

* chore: suffix update modal component

* fix: test snapshot

* fix: lint
Copy link
Contributor

@siepra siepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile part looks good

@EmiM EmiM mentioned this pull request Nov 22, 2023
@@ -33,6 +33,8 @@ import UnregisteredModalContainer from './components/widgets/userLabel/unregiste
import DuplicateModalContainer from './components/widgets/userLabel/duplicate/DuplicateModal.container'
import UsernameTakenModalContainer from './components/widgets/usernameTakenModal/UsernameTakenModal.container'
import PossibleImpersonationAttackModalContainer from './components/widgets/possibleImpersonationAttackModal/PossibleImpersonationAttackModal.container'
import BreakingChangesWarning from './containers/widgets/breakingChangesWarning/BreakingChangesWarning'
// Trigger lerna
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

@EmiM EmiM merged commit 16612aa into develop Nov 23, 2023
25 of 28 checks passed
@siepra siepra deleted the chore/master-to-develop branch December 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants