Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch errors of libp2p.ping #2109

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: catch errors of libp2p.ping #2109

merged 1 commit into from
Nov 22, 2023

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Nov 22, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@EmiM EmiM requested a review from Kacper-RF November 22, 2023 13:58
Kacper-RF
Kacper-RF approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmiM EmiM merged commit 08ba64b into develop Nov 22, 2023
12 of 17 checks passed
@EmiM EmiM deleted the fix/2108 branch November 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmiM @Kacper-RF