2625 port chainmanager from poc #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islathehut
requested changes
Nov 15, 2024
| return SigChain.lfa.invitation.generateProof(seed) | ||
| } | ||
|
|
||
| public validateProof(proof: ProofOfInvitation): boolean { |
There was a problem hiding this comment.
You can delete validateProof, admitUser, and admitMemberFromInvite. This is handled by the LFA Connection class we use in libp2p.
There was a problem hiding this comment.
These are useful in testing so I'm going to leave them in for now I think
islathehut
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic Sigchain classes and tests
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: