fix(2679): Fix issue with download buttons missing from large files #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the regression tests are failing, |
adrastaea
approved these changes
Jan 7, 2025
islathehut
added a commit
that referenced
this pull request
Jan 27, 2025
* Update orbitdb (#2600) * WIP: Update OrbitDB/IPFS/libp2p * Various updates * Various updates * Fixes * Updates * Clean up NestJS modules and fix storage.service tests * Fixes, mostly around restarting app * Use custom storage to ensure we write data as Uint8array + rename OrbitdbService * Ignore logs * More storage related stuff * (Maybe) fix the ping issue and mild refactor for my sanity * Fix reconnections and update logging * Get desktop to run without the customevent flag * Mobile testing * Ensure mobile can function with JS customevents * Fix for issue with not having all blocks * Fix common tests * Fix almost all tests on the backend, etc. * Fix for customevent errors in ci tests * Fix state manager test and backend test node options * Update class-validator * Test mac e2e ci issue * Fix tor binary dir issue in ci * Try again * Random fixes for e2e tests * Fix file manager * Fix code scanning alert no. 1: Insecure randomness Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Some digging on why the backend process isn't starting on linux * Not sure why this didn't show up as errors in vscode * Get fork argv * Remove debug code and add patch for connection monitor * Log everything * Remove env variables as test * Fix url scheme handler error on linux * Remove debug logging * Trying something * See if we can bypass error I'm seeing on linux * Put logs back to a sane level * Reorder e2e test cases so we can guarantee everything has a chance to run * Updating dependencies for mobile * Add helia as a package * Revert "Updating dependencies for mobile" This reverts commit bcb9a2a. * Some minor updates * Fix logging and get rid of annoying malformed rn-bridge error on background * Cleanup, fix ios resume, add volta params * Ensure helia is bootstrapped in CI * Fix up closing and make sure tests exit when they finish * E2E test updates * Merge branch 'develop' into update-orbitdb * Fix the duplicated/unregistered bug * Invitation link is failing consistently so do it last * Try macos-14 * Update CSRs test since the order that orbitdb returns events in changed * Fix jest issue * Fix connection manager tests * Use macos-13 * Log test name on all test cases in e2e * Reformat and update back compat version * Don't run back compat tests on this branch * Add log to invitation * Remove empty if * Add back old xdg-settings call * Get branch correctly on CI * Fix vulnerable dependencies * Do a better job - why didn't they upgrade a vulnerable package when releasing a major version? * Check something * Try something again * Try this method * Not * Test * Update e2e-linux.yml * Update e2e-linux.yml * remove print statement * Use windows latest * Use windows latest large * Switch back * Remove node_datachannel references * Remove inaccurate comments * Remove unnecessary changes * Share the same constants and enums with identity * Merge remote-tracking branch 'origin/develop' into update-orbitdb * Update PEER_ID_REGEX to match 52-character peer IDs * generate random device name instead of using mac * fix connections manager test * Fix leave community issue * Fix common tests * Fix backend tests * Update snapshots * Purge ALL data * add extension error handling * fix bigfiles test * Add file upload test cases for single user * Add file upload/download/cancel test cases for multiple users * fix snapshots * Generate big test file at runtime * E2E refactor to (mostly) not use sleep statements * Add extra visibility checks --------- Co-authored-by: Lucas Leblow <[email protected]> Co-authored-by: Isla Koenigsknecht <[email protected]> Co-authored-by: Isla Koenigsknecht <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Taea Vogel <[email protected]> * Update CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Split file generation logic apart because fs import breaks mobile * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * chore: Upgrade orbitdb to 2.4.3 (#2684) * Upgrade to orbitdb 2.4.3 (with libp2p 2.x and helia 5.x) * Fix leave community * Mild test fixes * Fix file manager download test * Fix connections manager tests * Remove unused keys * Undo logging and try to fix linux tests * submodule stuff * Go back to helia as a package * Forgot one * Workaround for failing test cleanup * Add back compat skip branch * Upgrade to node 18.20.4 to support noise as a submodule * Fix build in CI * Add noise submodule to get the latest code without WASM * Reuse noise keys and fix some libp2p settings * Update CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * fix: Fixes download issues on cancellation, download status logs, connection stability (#2687) * Fix download issues and improve connections * Update e2e-linux.yml * Some mild updates to help with initial connections and connection stability * Mild dependency update * Mild abort improvements and make the file component more legible * Fix snapshots * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * fix(2679): Fix issue with download buttons missing from large files (#2690) * Fix issue with download buttons not showing for large files * Fix snapshot * Fix regression tests * Update regression test runner and snapshots * Try to force cypress install on ci * Custom cache key for cypress runs * Get rid of debug logs * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Add back debug logging * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Fix/download connection issues (#2691) * Testing changes * A couple more changes * Refactor file manager service, fix cancel crash, tweak logging * This might fix the files not being downloadable... * Remove these patches * Run backend prepare to figure out why its failing * I'm dumb * I'm really dumb * Not sure why this fails on CI * Don't send canceled status for malicous downloads and fix tests * Forgot this * Update mobile-deploy-ios-test.yml * Update action.yml * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Add timeouts (optional) and make more iterators abortable (#2694) * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Fix/more connection nonsense (#2695) * More connection tweaks, add connected peers interval, better handling of abortable generators * Update websocket files to better match current websocket transport in libp2p * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Add mplex (#2696) * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Update mplex config and improve logging (#2701) * Update mplex config and improve logging * Oops I broke joining * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Return when already downloading a file (#2702) * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * chore(2672): Update directories and S3 bucket for 3.0 release (#2706) * Update data directory for 3.0 * Update files directory for 3.0 * Update desktop install directory * Update CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Update build.gradle * Publish - @quiet/[email protected] - @quiet/[email protected] * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md * Publish - @quiet/[email protected] - @quiet/[email protected] * Publish - @quiet/[email protected] - @quiet/[email protected] * Update packages CHANGELOG.md --------- Co-authored-by: Lucas Leblow <[email protected]> Co-authored-by: Lucas Leblow <[email protected]> Co-authored-by: Isla Koenigsknecht <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Taea Vogel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: