Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit asset timeframe partitions #1011

Conversation

datejada
Copy link
Member

@datejada datejada commented Feb 4, 2025

This PR unifies the default value of the partitions for the representatives and the timeframe. So, if no data is defined in the partition files, the default partition is uniform of value 1.

Related issues

Closes #1009

Checklist

  • I am following the contributing guidelines

  • Tests are passing

  • Lint workflow is passing

  • Docs were updated and workflow is passing

@datejada datejada added the benchmark PR only - Run benchmark on PR label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (8ee7150) to head (17c4e3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          29       29           
  Lines        1151     1152    +1     
=======================================
+ Hits         1096     1097    +1     
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada
Copy link
Member Author

datejada commented Feb 4, 2025

closing this one in favor of #1012 to run the benchmarks

@datejada datejada closed this Feb 4, 2025
@datejada datejada deleted the 1009-allow-explicit-timeframe-partitions branch February 5, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default values for assets_timeframe_partitions table
1 participant