Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new columns to the rp file #195

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Oct 25, 2023

Pull request details

Describe the changes made in this pull request

Add new columns to the Norse and tiny rp files.
Update input_tables RepPeriodData schema.

List of related issues or pull requests

Closes #179

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@abelsiqueira abelsiqueira requested a review from datejada October 25, 2023 13:58
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! no comments

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@abelsiqueira abelsiqueira merged commit 3ff59a1 into TulipaEnergy:main Oct 25, 2023
5 checks passed
@gnawin gnawin deleted the 179-modify-rp-file branch February 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add number of time steps and time scale to RP file
3 participants