Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put tests in separate files #196

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

clizbe
Copy link
Member

@clizbe clizbe commented Oct 25, 2023

Pull request details

Describe the changes made in this pull request

Created separate files for each test area, based on the names of the src files.
Might need some editing to clean it up - such as test_TulipaEnergyModel that tests functions in model.jl and io.jl etc.

List of related issues or pull requests

Closes #152

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file names need some OCD love: Use only kebab-case or snake_case.
Also, I would prefer using a different file name for the general. We discussed offline using test-case-studies.

@clizbe clizbe requested a review from abelsiqueira October 25, 2023 14:38
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/TulipaEnergyModel.jl 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@abelsiqueira abelsiqueira merged commit c245e1c into TulipaEnergy:main Oct 25, 2023
5 checks passed
@clizbe clizbe deleted the 152_test_files branch October 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize tests into different files
2 participants