Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model the different time resolutions #212

Merged

Conversation

abelsiqueira
Copy link
Member

Pull request details

Describe the changes made in this pull request

WIP

List of related issues or pull requests

Closes #110

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/io.jl 100.00% <100.00%> (ø)
src/model.jl 100.00% <100.00%> (ø)
src/time-resolution.jl 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@abelsiqueira abelsiqueira force-pushed the 110-model-time-resolution branch 2 times, most recently from c5c7c2b to d05ce29 Compare November 1, 2023 14:09
@abelsiqueira abelsiqueira force-pushed the 110-model-time-resolution branch from d05ce29 to 185cb34 Compare November 1, 2023 14:11
@abelsiqueira abelsiqueira marked this pull request as ready for review November 1, 2023 14:12
@abelsiqueira abelsiqueira requested a review from datejada November 1, 2023 14:12
@abelsiqueira
Copy link
Member Author

/run-benchmark

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great job!

@abelsiqueira abelsiqueira merged commit 8d13c70 into TulipaEnergy:main Nov 1, 2023
6 checks passed
@abelsiqueira abelsiqueira deleted the 110-model-time-resolution branch November 1, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the temporal parameters in the constraints
2 participants