[WIP] Add ESDL XML reader #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
===========================================
- Coverage 100.00% 90.44% -9.56%
===========================================
Files 5 5
Lines 236 272 +36
===========================================
+ Hits 236 246 +10
- Misses 0 26 +26 ☔ View full report in Codecov by Sentry. |
NOTE: asset-to-graph conversion is currently very lenient with incomplete connections. Test cases have also not yet been updated to be complete & valid
sjvrijn
force-pushed
the
89-ESDL-reader
branch
from
e6f6ee2 to
a2f9215
Compare
|
This may be unneeded if we use a JSON instead. |
|
@suvayu If we've decided to use JSON, can we close this PR? |
|
I'ld like to leave this open until we also get the other attributes |
|
@suvayu Can we close it now? 🙃 |
|
sorry, forgot about this alternative. I'll close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
Describe the changes made in this pull request
Writing a reader to take an ESDL/XML file and turn it into a Julia graph for further internal usage
List of related issues or pull requests
Closes #89
Collaboration confirmation
As a contributor I confirm