Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single-letter prefix for expressions and constraints #232

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

abelsiqueira
Copy link
Member

Pull request details

Describe the changes made in this pull request

Removes e_ and c_.

List of related issues or pull requests

Closes #229

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@abelsiqueira
Copy link
Member Author

abelsiqueira commented Nov 7, 2023

/run-benchmark

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/model.jl 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Judge result
≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Benchmark Report for
/home/runner/work/TulipaEnergyModel.jl/TulipaEnergyModel.jl
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Job Properties

•  Time of benchmarks:
   • Target: 7 Nov 2023 - 09:52
   • Baseline: 7 Nov 2023 - 09:54

•  Package commits:
   • Target: 036eeb
   • Baseline: 036eeb

•  Julia commits:
   • Target: bed2cd
   • Baseline: bed2cd

•  Julia command flags:
   • Target: None
   • Baseline: None

•  Environment variables:
   • Target: None
   • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌),
while a ratio less than 1.0 denotes a possible improvement (marked with
:whitecheckmark:). Only significant results - results that indicate possible
regressions or improvements - are shown below (thus, an empty table means
that all benchmark results remained invariant between builds).

          ID                 time ratio memory ratio

–––––––––––––––– –––––––––––––––––––––––––– ––––––––––––
["io", "input"] 0.91 (5%) :whitecheckmark: 1.00 (1%)
["io", "output"] 0.81 (5%) :whitecheckmark: 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

•  ["io"]

•  ["model"]

Julia versioninfo

Target
––––––––

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Linux (x86_64-linux-gnu)
Ubuntu 22.04.3 LTS
uname: Linux 6.2.0-1015-azure #15~22.04.1-Ubuntu SMP Fri Oct 6 13:20:44 UTC 2023 x86_64 x86_64
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz:
speed user nice sys idle irq
#1 2793 MHz 3763 s 0 s 159 s 2673 s 0 s
#2 2793 MHz 2100 s 0 s 186 s 4298 s 0 s
Memory: 6.7597503662109375 GB (4989.9140625 MB free)
Uptime: 667.88 sec
Load Avg: 1.03 1.06 0.6
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
Threads: 1 on 2 virtual cores

Baseline
––––––––––

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Linux (x86_64-linux-gnu)
Ubuntu 22.04.3 LTS
uname: Linux 6.2.0-1015-azure #15~22.04.1-Ubuntu SMP Fri Oct 6 13:20:44 UTC 2023 x86_64 x86_64
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz:
speed user nice sys idle irq
#1 2793 MHz 4034 s 0 s 171 s 3393 s 0 s
#2 2793 MHz 2822 s 0 s 198 s 4574 s 0 s
Memory: 6.7597503662109375 GB (5010.2890625 MB free)
Uptime: 769.43 sec
Load Avg: 1.0 1.04 0.64
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
Threads: 1 on 2 virtual cores

────────────────────────────────────────────────────────────────────────────

Target result
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Benchmark Report for
/home/runner/work/TulipaEnergyModel.jl/TulipaEnergyModel.jl
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Job Properties

•  Time of benchmark: 7 Nov 2023 - 9:52

•  Package commit: 036eeb

•  Julia commit: bed2cd

•  Julia command flags: None

•  Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group,
child_group, ..., key], and can be used to index into the BaseBenchmarks
suite to retrieve the corresponding benchmarks. The percentages accompanying
time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this
percentage of the reported value. An empty cell means that the value was
zero.

                     ID           time    GC time          memory allocations

––––––––––––––––––––––––– –––––––––––––– –––––––––– ––––––––––––––– –––––––––––
["io", "graph"] 2.389 ms (5%) 172.80 KiB (1%) 4705
["io", "input"] 29.888 ms (5%) 1.43 MiB (1%) 29318
["io", "output"] 62.000 μs (5%) 4.01 MiB (1%) 118
["model", "create_model"] 1.169 s (5%) 148.976 ms 665.40 MiB (1%) 9720874
["model", "solve_model"] 14.475 s (5%) 1.87 MiB (1%) 61043

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

•  ["io"]

•  ["model"]

Julia versioninfo

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Linux (x86_64-linux-gnu)
Ubuntu 22.04.3 LTS
uname: Linux 6.2.0-1015-azure #15~22.04.1-Ubuntu SMP Fri Oct 6 13:20:44 UTC 2023 x86_64 x86_64
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz:
speed user nice sys idle irq
#1 2793 MHz 3763 s 0 s 159 s 2673 s 0 s
#2 2793 MHz 2100 s 0 s 186 s 4298 s 0 s
Memory: 6.7597503662109375 GB (4989.9140625 MB free)
Uptime: 667.88 sec
Load Avg: 1.03 1.06 0.6
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
Threads: 1 on 2 virtual cores

────────────────────────────────────────────────────────────────────────────

Baseline result
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Benchmark Report for
/home/runner/work/TulipaEnergyModel.jl/TulipaEnergyModel.jl
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Job Properties

•  Time of benchmark: 7 Nov 2023 - 9:54

•  Package commit: 036eeb

•  Julia commit: bed2cd

•  Julia command flags: None

•  Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group,
child_group, ..., key], and can be used to index into the BaseBenchmarks
suite to retrieve the corresponding benchmarks. The percentages accompanying
time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this
percentage of the reported value. An empty cell means that the value was
zero.

                     ID           time    GC time          memory allocations

––––––––––––––––––––––––– –––––––––––––– –––––––––– ––––––––––––––– –––––––––––
["io", "graph"] 2.339 ms (5%) 172.80 KiB (1%) 4705
["io", "input"] 32.906 ms (5%) 1.43 MiB (1%) 29318
["io", "output"] 76.400 μs (5%) 4.01 MiB (1%) 118
["model", "create_model"] 1.208 s (5%) 171.360 ms 665.40 MiB (1%) 9720874
["model", "solve_model"] 14.463 s (5%) 1.87 MiB (1%) 61043

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

•  ["io"]

•  ["model"]

Julia versioninfo

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Linux (x86_64-linux-gnu)
Ubuntu 22.04.3 LTS
uname: Linux 6.2.0-1015-azure #15~22.04.1-Ubuntu SMP Fri Oct 6 13:20:44 UTC 2023 x86_64 x86_64
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz:
speed user nice sys idle irq
#1 2793 MHz 4034 s 0 s 171 s 3393 s 0 s
#2 2793 MHz 2822 s 0 s 198 s 4574 s 0 s
Memory: 6.7597503662109375 GB (5010.2890625 MB free)
Uptime: 769.43 sec
Load Avg: 1.0 1.04 0.64
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
Threads: 1 on 2 virtual cores

────────────────────────────────────────────────────────────────────────────

Runtime information
≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

Runtime Info
––––––––––––––– –––
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
CPU family: 6
Model: 106
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 6
BogoMIPS: 5586.87
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 96 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2.5 MiB (2 instances)
L3 cache: 48 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
–––––––––––––––––– –––––––––––––––––––––––––––––––––––––––––––––––––––––––
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it looks much better :)

@datejada datejada merged commit 77c4e3c into TulipaEnergy:main Nov 7, 2023
6 checks passed
@abelsiqueira abelsiqueira deleted the 229-expressions-name branch November 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standarised all the expression's name in the optimisation model without e_
2 participants