Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename time symbols #240

Merged

Conversation

greg-neustroev
Copy link
Contributor

Pull request details

Describe the changes made in this pull request

Rename symbols according to #208

List of related issues or pull requests

Closes #208

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/io.jl 100.00% <100.00%> (ø)
src/model.jl 100.00% <100.00%> (ø)
src/time-resolution.jl 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@greg-neustroev greg-neustroev merged commit 7fcc0c3 into TulipaEnergy:main Nov 8, 2023
6 checks passed
@greg-neustroev greg-neustroev deleted the 208-rename-time-symbols branch November 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better name for time resolution "stuff"
2 participants