-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ramping file with new attach_constraint and create new tables #965
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 95.27% 94.85% -0.43%
==========================================
Files 29 29
Lines 1059 1049 -10
==========================================
- Hits 1009 995 -14
- Misses 50 54 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed through peer programming
66d1b9e
to
9cb0342
Compare
Co-authored-by: Diego Alejandro Tejada Arango <[email protected]>
src/constraints/create.jl
Outdated
", | ||
) | ||
|
||
# TODO: Should there be a `AND NOT asset.unit_commitment` in the WHERE here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datejada, this was a question I had when looking at these tables. The without_unit_commitment
doesn't check for asset.unit_commitment = false
or NOT asset.unit_commitment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We need to add those checks in the SQL query. Thanks!
Done. I re-requested your review but I'm not working anymore today. If I work before our Monday meeting, I'll just merge |
Update ramp file with new attach_constraint, create new tables and change from groupby to loop over the entire table (to use the attach).
Depends on #963
Closes #964