Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ramping file with new attach_constraint and create new tables #965

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Dec 13, 2024

Update ramp file with new attach_constraint, create new tables and change from groupby to loop over the entire table (to use the attach).

Depends on #963

Closes #964

@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Benchmark Results

d42650e... 5cbddfc... d42650e.../5cbddfc5658e6d...
energy_problem/create_model 41.6 ± 2.2 s 40.9 ± 1.3 s 1.02
energy_problem/input_and_constructor 15.2 ± 0.098 s 14.9 ± 0.24 s 1.02
time_to_load 4.21 ± 0.15 s 4.01 ± 0.019 s 1.05
d42650e... 5cbddfc... d42650e.../5cbddfc5658e6d...
energy_problem/create_model 0.611 G allocs: 21 GB 0.611 G allocs: 21.3 GB 0.987
energy_problem/input_and_constructor 0.0432 G allocs: 1.69 GB 0.0432 G allocs: 1.69 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (d42650e) to head (5cbddfc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/constraints/ramping-and-unit-commitment.jl 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   95.27%   94.85%   -0.43%     
==========================================
  Files          29       29              
  Lines        1059     1049      -10     
==========================================
- Hits         1009      995      -14     
- Misses         50       54       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed through peer programming

Co-authored-by: Diego Alejandro Tejada Arango <[email protected]>
",
)

# TODO: Should there be a `AND NOT asset.unit_commitment` in the WHERE here?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datejada, this was a question I had when looking at these tables. The without_unit_commitment doesn't check for asset.unit_commitment = false or NOT asset.unit_commitment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We need to add those checks in the SQL query. Thanks!

@abelsiqueira abelsiqueira changed the title 964 update ramp file Update ramping file with new attach_constraint and create new tables Dec 13, 2024
@abelsiqueira
Copy link
Member Author

Done. I re-requested your review but I'm not working anymore today. If I work before our Monday meeting, I'll just merge

@abelsiqueira abelsiqueira marked this pull request as ready for review December 16, 2024 05:26
@abelsiqueira abelsiqueira merged commit 59174a4 into main Dec 16, 2024
4 of 7 checks passed
@abelsiqueira abelsiqueira deleted the 964-update-ramp-file branch December 16, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename, split, create new constraints for ramping-and-unit-commitment.jl
2 participants