Use attach_constraint for src/constraints/storage.jl

[abelsiqueira]

Use attach_constraint for balance_storage_rep_period.
Use attach_constraint for balance_storage_over_clustered_year.
Move variable bounds to src/variables/storage and clean up.

Closes #966

[github-actions]

Benchmark Results

	59174a4...	cabe9fb...	59174a4.../cabe9fbebf7ec5...
energy_problem/create_model	40.7 ± 1.3 s	39.2 ± 0.99 s	1.04
energy_problem/input_and_constructor	14.6 ± 0.34 s	14.7 ± 0.23 s	0.995
time_to_load	3.96 ± 0.0084 s	3.96 ± 0.016 s	1

	59174a4...	cabe9fb...	59174a4.../cabe9fbebf7ec5...
energy_problem/create_model	0.611 G allocs: 21.3 GB	0.614 G allocs: 21.3 GB	0.999
energy_problem/input_and_constructor	0.0432 G allocs: 1.69 GB	0.0432 G allocs: 1.69 GB	1
time_to_load	0.159 k allocs: 11.2 kB	0.159 k allocs: 11.2 kB	1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (59174a4) to head (cabe9fb).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   94.85%   94.91%   +0.06%     
==========================================
  Files          29       29              
  Lines        1049     1062      +13     
==========================================
+ Hits          995     1008      +13     
  Misses         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datejada]

Reviewed by pair programming