-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename, split, create new constraints for group.jl #972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 94.93% 94.96% +0.02%
==========================================
Files 29 29
Lines 1066 1072 +6
==========================================
+ Hits 1012 1018 +6
Misses 54 54 ☔ View full report in Codecov by Sentry. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@abelsiqueira this PR is ready for review. There are two things that might be better to address in separate issues:
Let me know what you think about doing it like this or if you prefer to include those changes here as well. P.S. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! I agree with doing the other tasks in a separate PR
There is apparently a conflict with |
yeap, because I merged the changes for the transport. But, it is an easy rebase 😄 |
cb0e178
to
cb6b285
Compare
It's approved, so feel free to merge whenever you're ready |
Related issues
Closes #969
Checklist