Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename, split, create new constraints for group.jl #972

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

datejada
Copy link
Member

@datejada datejada commented Dec 16, 2024

Related issues

Closes #969

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (606766e) to head (cb6b285).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   94.93%   94.96%   +0.02%     
==========================================
  Files          29       29              
  Lines        1066     1072       +6     
==========================================
+ Hits         1012     1018       +6     
  Misses         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada added the benchmark PR only - Run benchmark on PR label Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Benchmark Results

606766e... cb6b285... 606766e.../cb6b285b1f6aab...
energy_problem/create_model 39.7 ± 2.5 s 40.7 ± 2.1 s 0.974
energy_problem/input_and_constructor 14.9 ± 0.32 s 14.8 ± 0.19 s 1.01
time_to_load 3.95 ± 0.031 s 3.92 ± 0.0073 s 1.01
606766e... cb6b285... 606766e.../cb6b285b1f6aab...
energy_problem/create_model 0.615 G allocs: 21.3 GB 0.615 G allocs: 21.3 GB 1
energy_problem/input_and_constructor 0.0436 G allocs: 1.71 GB 0.0436 G allocs: 1.71 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@datejada datejada marked this pull request as ready for review December 18, 2024 08:26
@datejada
Copy link
Member Author

@abelsiqueira this PR is ready for review. There are two things that might be better to address in separate issues:

  1. Getting rid of the sets to create the expression for the group constraints
  2. After 1, deleting the group structure. It will be useless after that

Let me know what you think about doing it like this or if you prefer to include those changes here as well.

P.S. group is poor choice for names in SQL 😆 it gave a couple of headaches. e.g., I still need to call the first column of the file as name since using group gave errors with SQL 🙄

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! I agree with doing the other tasks in a separate PR

@abelsiqueira
Copy link
Member

There is apparently a conflict with src/constraints/create.jl

@datejada
Copy link
Member Author

There is apparently a conflict with src/constraints/create.jl

yeap, because I merged the changes for the transport. But, it is an easy rebase 😄

@datejada datejada force-pushed the 969-rename-split-create-new-cons-group branch from cb0e178 to cb6b285 Compare December 18, 2024 09:14
@abelsiqueira
Copy link
Member

It's approved, so feel free to merge whenever you're ready

@datejada datejada merged commit a6a9b22 into main Dec 18, 2024
5 of 7 checks passed
@datejada datejada deleted the 969-rename-split-create-new-cons-group branch December 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename, split, create new constraints for group.jl
2 participants