Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary expression and move lower bound of flow variable from src/constraints/capacity.jl #976

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Dec 18, 2024

  • Remove unnecessary accumulated_investment_limit expression
  • Move lower bound of flow variable from capacity.jl to variable creation

Related to #961

@abelsiqueira abelsiqueira changed the title 961 capacity Remove unnecessary expression and move lower bound of flow variable from src/constraints/capacity.jl Dec 18, 2024
@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Benchmark Results

b34be57... 763bb82... b34be57.../763bb82686e971...
energy_problem/create_model 40.5 ± 1.5 s 42.6 ± 0.96 s 0.952
energy_problem/input_and_constructor 16.3 ± 0.084 s 16.5 ± 0.26 s 0.989
time_to_load 3.97 ± 0.017 s 4.11 ± 0.076 s 0.965
b34be57... 763bb82... b34be57.../763bb82686e971...
energy_problem/create_model 0.614 G allocs: 21.3 GB 0.603 G allocs: 21.6 GB 0.987
energy_problem/input_and_constructor 0.0436 G allocs: 1.71 GB 0.0436 G allocs: 1.71 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.84%. Comparing base (606766e) to head (763bb82).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/variables/flows.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   94.93%   94.84%   -0.10%     
==========================================
  Files          29       29              
  Lines        1066     1066              
==========================================
- Hits         1012     1011       -1     
- Misses         54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira marked this pull request as ready for review December 18, 2024 10:45
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during online meeting

@datejada datejada merged commit 0a1e15b into main Dec 18, 2024
5 of 8 checks passed
@datejada datejada deleted the 961-capacity branch December 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants