Enable Electron fuses in production builds #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarboMuffin
changed the title
GarboMuffin
force-pushed
the
electron-fuses
branch
from
2e7e87c to
8531796
Compare
GarboMuffin
added a commit
that referenced
this pull request
Oct 8, 2023
This reverts commit e5ebf8f. Doesn't actually work in the final electron-builder binaries electron-builder also does not support the ASAR integrity values yet, so we can't really use this at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some security things. Notably helps prevent tampering with the asar on macOS, which could have some system security impact as our app has camera and microphone entitlements