Unused variables are now an ESLint error (#1305)

If it's not used then why is it there?
TurboWarp · Feb 18, 2024 · e252617 · e252617
1 parent 5212671
commit e252617
Show file tree

Hide file tree

Showing 14 changed files with 22 additions and 110 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,7 +17,19 @@ module.exports = {
     scaffolding: 'readonly'
   },
   rules: {
-    'no-unused-vars': 'off',
+    // Unused variables commonly indicate logic errors
+    'no-unused-vars': [
+      'error',
+      {
+        // Unused arguments are useful, eg. it can be nice for blocks to accept `args` even if they don't use it
+        args: 'none',
+        // Allow silently eating try { } catch { }
+        caughtErrors: 'none',
+        // Variables starting with _ are intentionally unused
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      }
+    ],
     // Allow while (true) { }
     'no-constant-condition': [
       'error',

diff --git a/extensions/0832/rxFS.js b/extensions/0832/rxFS.js
@@ -12,7 +12,7 @@
 
   var rxFSfi = new Array();
   var rxFSsy = new Array();
-  var Search, i, str, str2;
+  var Search, str, str2;
 
   const file =
     "data:image/svg+xml;base64,PHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHdpZHRoPSIzMC4zMTIxMiIgaGVpZ2h0PSIyNC4yNDk2NyIgdmlld0JveD0iMCwwLDMwLjMxMjEyLDI0LjI0OTY3Ij48ZyB0cmFuc2Zvcm09InRyYW5zbGF0ZSgtMzA0Ljg0Mzk0LC0xNjcuODc1MTYpIj48ZyBkYXRhLXBhcGVyLWRhdGE9InsmcXVvdDtpc1BhaW50aW5nTGF5ZXImcXVvdDs6dHJ1ZX0iIGZpbGw9IiNmZmI5MDAiIGZpbGwtcnVsZT0ibm9uemVybyIgc3Ryb2tlPSJub25lIiBzdHJva2Utd2lkdGg9IjEiIHN0cm9rZS1saW5lY2FwPSJidXR0IiBzdHJva2UtbGluZWpvaW49Im1pdGVyIiBzdHJva2UtbWl0ZXJsaW1pdD0iMTAiIHN0cm9rZS1kYXNoYXJyYXk9IiIgc3Ryb2tlLWRhc2hvZmZzZXQ9IjAiIHN0eWxlPSJtaXgtYmxlbmQtbW9kZTogbm9ybWFsIj48cGF0aCBkPSJNMzE5Ljk5OTk5LDE3MC45MDYzN2gxMi4xMjQ4M2MxLjY3NDEyLDAgMy4wMzEyNCwxLjM1NzEyIDMuMDMxMjQsMy4wMzEydjE1LjE1NjA3YzAsMS42NzQwOCAtMS4zNTcxMiwzLjAzMTIgLTMuMDMxMjQsMy4wMzEyaC0yNC4yNDk2NmMtMS42NzQxMiwwIC0zLjAzMTIyLC0xLjM1NzEyIC0zLjAzMTIyLC0zLjAzMTJ2LTE4LjE4NzI3YzAsLTEuNjgyMzIgMS4zNDg5LC0zLjAzMTIgMy4wMzEyMiwtMy4wMzEyaDkuMDkzNjN6Ii8+PC9nPjwvZz48L3N2Zz48IS0tcm90YXRpb25DZW50ZXI6MTUuMTU2MDYwMDAwMDAwMDI1OjEyLjEyNDgzNTAwMDAwMDAxOS0tPg==";

diff --git a/extensions/0832/rxFS2.js b/extensions/0832/rxFS2.js
@@ -17,7 +17,7 @@
 
   var rxFSfi = new Array();
   var rxFSsy = new Array();
-  var Search, i, str, str2;
+  var Search, str, str2;
 
   const folder =
     "data:image/svg+xml;base64,PHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHdpZHRoPSIyOC40NjI1IiBoZWlnaHQ9IjI3LjciIHZpZXdCb3g9IjAsMCwyOC40NjI1LDI3LjciPjxnIHRyYW5zZm9ybT0idHJhbnNsYXRlKC0yMjYuMDE5NTMsLTE2NC4xMTg3NSkiPjxnIGRhdGEtcGFwZXItZGF0YT0ieyZxdW90O2lzUGFpbnRpbmdMYXllciZxdW90Ozp0cnVlfSIgZmlsbD0iIzk5NjZmZiIgZmlsbC1ydWxlPSJub256ZXJvIiBzdHJva2U9Im5vbmUiIHN0cm9rZS13aWR0aD0iMSIgc3Ryb2tlLWxpbmVjYXA9ImJ1dHQiIHN0cm9rZS1saW5lam9pbj0ibWl0ZXIiIHN0cm9rZS1taXRlcmxpbWl0PSIxMCIgc3Ryb2tlLWRhc2hhcnJheT0iIiBzdHJva2UtZGFzaG9mZnNldD0iMCIgZm9udC1mYW1pbHk9IlNhbnMgU2VyaWYiIGZvbnQtd2VpZ2h0PSJub3JtYWwiIGZvbnQtc2l6ZT0iNDAiIHRleHQtYW5jaG9yPSJzdGFydCIgc3R5bGU9Im1peC1ibGVuZC1tb2RlOiBub3JtYWwiPjx0ZXh0IHRyYW5zZm9ybT0idHJhbnNsYXRlKDIyNi4yNjk1MywxODUuNzY4NzUpIHNjYWxlKDAuNSwwLjUpIiBmb250LXNpemU9IjQwIiB4bWw6c3BhY2U9InByZXNlcnZlIiBmaWxsPSIjOTk2NmZmIiBmaWxsLXJ1bGU9Im5vbnplcm8iIHN0cm9rZT0ibm9uZSIgc3Ryb2tlLXdpZHRoPSIxIiBzdHJva2UtbGluZWNhcD0iYnV0dCIgc3Ryb2tlLWxpbmVqb2luPSJtaXRlciIgc3Ryb2tlLW1pdGVybGltaXQ9IjEwIiBzdHJva2UtZGFzaGFycmF5PSIiIHN0cm9rZS1kYXNob2Zmc2V0PSIwIiBmb250LWZhbWlseT0iU2FucyBTZXJpZiIgZm9udC13ZWlnaHQ9Im5vcm1hbCIgdGV4dC1hbmNob3I9InN0YXJ0IiBzdHlsZT0ibWl4LWJsZW5kLW1vZGU6IG5vcm1hbCI+PHRzcGFuIHg9IjAiIGR5PSIwIj7wn5OBPC90c3Bhbj48L3RleHQ+PC9nPjwvZz48L3N2Zz48IS0tcm90YXRpb25DZW50ZXI6MTMuOTgwNDY4NzU6MTUuODgxMjQ5MjM3MDYwNTMtLT4=";

diff --git a/extensions/Lily/TempVariables2.js b/extensions/Lily/TempVariables2.js
@@ -6,8 +6,6 @@
 (function (Scratch) {
   "use strict";
 
-  const menuIconURI = "";
-
   // Object.create(null) prevents "variable [toString]" from returning a function
   let runtimeVariables = Object.create(null);
 

diff --git a/extensions/NOname-awa/cn-number.js b/extensions/NOname-awa/cn-number.js
@@ -1,21 +1,7 @@
 (function (Scratch) {
   "use strict";
 
-  let Number2,
-    null2,
-    units,
-    Number_in,
-    uppercase,
-    i,
-    N_Z,
-    o,
-    j,
-    After_decimal_point,
-    unit,
-    k,
-    C_Number,
-    m,
-    n;
+  let i, N_Z, o, j, After_decimal_point, unit, k, C_Number, m, n;
 
   class CNNUMBER {
     getInfo() {

diff --git a/extensions/NOname-awa/math-and-string.js b/extensions/NOname-awa/math-and-string.js
@@ -1156,22 +1156,6 @@
     return text.replace(new RegExp(oldStr, "g"), newStr);
   };
 
-  const sortAndUniqueWords_en = (text) => {
-    let words = text.toLowerCase().match(/\b\w+\b/g);
-    words = Array.from(new Set(words));
-    words.sort();
-    return words.join(" ");
-  };
-
-  const sortAndUniqueWords_cn = (text) => {
-    let words = text.match(/[^\u4e00-\u9fa5]+|[\u4e00-\u9fa5]+/g);
-    words = Array.from(new Set(words));
-    words.sort(function (a, b) {
-      return a.localeCompare(b, "zh-Hans-CN", { sensitivity: "accent" });
-    });
-    return words.join(" ");
-  };
-
   const countKeyword = (sentence, keyword) => {
     const count = (sentence.match(new RegExp(keyword, "gi")) || []).length;
     return count;

diff --git a/extensions/TheShovel/profanity.js b/extensions/TheShovel/profanity.js
@@ -1,6 +1,7 @@
 (function (Scratch) {
   "use strict";
 
+  // eslint-disable-next-line no-unused-vars
   const encode = (str) =>
     btoa(str)
       .split("")

diff --git a/extensions/ar.js b/extensions/ar.js
@@ -27,7 +27,6 @@
   let xrSession = null;
   let xrState = false;
   let xrRefSpace;
-  let xrViewSpace;
   let xrProjectionMatrix;
   let xrTransform;
   let xrCombinedMatrix;
@@ -82,7 +81,6 @@
   const onSuccess = function (session) {
     xrSession = session;
     xrRefSpace = null;
-    xrViewSpace = null;
     xrHitTestSource = null;
     hitPosition = null;
     hitPositionAvailable = false;
@@ -103,7 +101,6 @@
     session
       .requestReferenceSpace("viewer")
       .then((viewSpace) => {
-        xrViewSpace = viewSpace;
         return session.requestHitTestSource({ space: viewSpace });
       })
       .then((hts) => {
@@ -500,7 +497,6 @@
       }
       stageWrapperParent = stageWrapper.parentElement;
 
-      const noop = () => {};
       navigator.xr
         .requestSession("immersive-ar", {
           requiredFeatures: ["hit-test", "dom-overlay"],

diff --git a/extensions/docs-examples/unsandboxed/every-second.js b/extensions/docs-examples/unsandboxed/every-second.js
@@ -18,6 +18,7 @@
   }
   // highlight-start
   setInterval(() => {
+    // eslint-disable-next-line no-unused-vars
     const startedThreads = Scratch.vm.runtime.startHats('everysecondexample_everySecond');
   }, 1000);
   // highlight-end

diff --git a/extensions/gamejolt.js b/extensions/gamejolt.js
@@ -20,9 +20,11 @@
     function hex_md5(a) {
       return rstr2hex(rstr_md5(str2rstr_utf8(a)));
     }
+    // eslint-disable-next-line no-unused-vars
     function hex_hmac_md5(a, b) {
       return rstr2hex(rstr_hmac_md5(str2rstr_utf8(a), str2rstr_utf8(b)));
     }
+    // eslint-disable-next-line no-unused-vars
     function md5_vm_test() {
       return hex_md5("abc").toLowerCase() == "900150983cd24fb0d6963f7d28e17f72";
     }

diff --git a/extensions/obviousAlexC/SensingPlus.js b/extensions/obviousAlexC/SensingPlus.js
@@ -278,8 +278,6 @@
 
   const touchPointsArray = makeArrayOfTouches(); //* <-- Do this for devices that really can't support that many touches.
 
-  const alreadyTapped = {};
-
   class SensingPlus {
     getInfo() {
       return {