Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamejolt: major update #1106

Merged
merged 15 commits into from
Nov 1, 2023
Merged

gamejolt: major update #1106

merged 15 commits into from
Nov 1, 2023

Conversation

softedco
Copy link
Contributor

@softedco softedco commented Oct 22, 2023

Changes

  • Added docs.
  • Replaced some blocks with more efficient ones, replaced blocks marked as deprecated.
  • Added batch blocks.
    There isn't any way to independently test them without a game so we'll need people that are devs on GJ,
    here are the api docs, they cover what fields and params namespaces have, and the extension got rest of the URL construction covered.
  • Added debug mode and debug blocks, debug mode solves error messages being interpreted as a valid response, on by default to prevent significant block behaviour change.
  • Unwrapped some resolves to put the error message into err.last for the Last API error block to work properly, solves people improperly using non-returning blocks and telling me that the extension is not working instead of opening the console to see the errors. Thought of doing this with alerts but that would significantly change most existing projects' behaviour.
  • Changed text on blocks and some error messages to be more readable.
  • Changed GameJolt to Game Jolt because apparently Game Jolt with a space is their actual name, didn't check if this breaks something because it shouldn't (IDs and ID-like stuff untouched)

And most importantly

  • The bool object is now just trueStr.

Wrapping up

Lint will probably complain about data.stuff = undefined;.
It is there to make blocks not skip errors.
scratchblocks (2)

Should be it.

@softedco
Copy link
Contributor Author

scratchblocks (3)

also added the handling common errors section
also added handling common errors section
@softedco
Copy link
Contributor Author

softedco commented Oct 24, 2023

  • Batch blocks are now safer and easier to use.
  • Batch blocks are now documented.
  • Documentation now also features the Handling Common Errors section.

Upd: rip diff counter

because of how poorly designed the old trophy fetching block was I completely forgot it had additional functionality
fixed not a function errors and a typo,
also fixed trophyReturn when the object is not an array
im too lazy to use git to do all of this in one commit
@softedco softedco changed the title gamejolt: harder, better, faster, stronger gamejolt: major update Oct 27, 2023
@GarboMuffin
Copy link
Member

same as last time I don't really have a way to test this, so will just have to trust you

@GarboMuffin GarboMuffin merged commit 396de07 into TurboWarp:master Nov 1, 2023
3 checks passed
@softedco
Copy link
Contributor Author

softedco commented Nov 1, 2023

same as last time I don't really have a way to test this, so will just have to trust you

I tested the blocks with @devid.bitt.five. on the discord server / extdev / search: batch blocks (no thread cuz I forgor)
They seem to be working fine, and most of the other blocks' core functionality went untouched apart from some of them being split into separate blocks for efficient data extraction

1 similar comment
@softedco

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants