Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a run Javascript extension #1117

Closed
wants to merge 5 commits into from
Closed

Conversation

mark0o
Copy link

@mark0o mark0o commented Oct 28, 2023

image

You can use this extension to run simple JS code and APIs. I would love to hear your opinions, maybe to change something. If I did something wrong, please tell me, because this is my first proper extension.

Also, could someone help me with the checks? I would be very thankful. 😀👍

@CubesterYT
Copy link
Member

This extension will undoubtedly be denied. Eval is banned from use in TW Extensions due to it being able to run malicious code.

You can find more about it here, which is a preexisting PR for a JS extension: #570

@softedco
Copy link
Contributor

Please read CONTRIBUTING.md
You are not passing the checks because eval and arbitrary js evaluation are not allowed.

@GarboMuffin
Copy link
Member

see above

@GarboMuffin GarboMuffin added the invalid This doesn't seem right label Oct 30, 2023
@LilyMakesThings
Copy link
Contributor

GarboMuffin is extremely lenient about what is accepted. Getting extensions accepted is not a right it's a privilege and the safeguards that are in place for extensions on the gallery for things like eval are there to protect people from losing their scratch accounts, credit card details, etc.

It is listed in the contributing guidelines, that I am sure you read before submitting this, that extensions with unrestricted eval will not be accepted.

If you would like to share the extension with friends you still can, just not on the gallery. Also maybe inform them how extremely dangerous it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants