utilities: fix some blocks breaking if specific costumes exist #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarboMuffin
reviewed
Oct 30, 2023
|
extensions are supposed to cast all of their inputs themselves, for example when someone drops in a variable you don't know what you're going to get. in this case not casting inputs to numbers if it matches the name of a costume fixes compatibility bugs with "set costume to (...)" blocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #Clamp bug
For some weird, inexplicable reason that I do not know why it happens, ArgumentType.NUMBER arguments are auto-casted to number, but only if a costume with that name does not exist.
This breaks a few math-related blocks in Utilities under specific circumstances (for example,
clamp 30 between 25 and 100returns25if costumes named 25 and 100 exist).This PR fixes that, by casting the arguments to numbers in
clampand using Scratch.Cast.compare onisLessOrEqualandisMoreOrEqual.exponent's arguments are also casted now just to be safe.