Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding custom shadow argument reporters (SB part) #20

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

yuri-kiss
Copy link
Member

@yuri-kiss yuri-kiss commented Feb 11, 2025

VM: TurboWarp/scratch-vm#246

Resolves

Having to do a weird patch for it.

Proposed Changes

Allows you to add your own custom shadow argument reporters. (reporters that duplicate when they are shadowed and dragged)

Reason for Changes

See #Resolves

Test Coverage

No tests, this is very simple

@CST1229
Copy link

CST1229 commented Feb 11, 2025

I think it would be better to have this as a property on the block, and then register an extension (like shadow_argument_reporter) that sets that property. Then it could be put into the extensions property, but oh wait that might not work in cases where the extension does not exists so uh

@yuri-kiss
Copy link
Member Author

I think it would be better to have this as a property on the block, and then register an extension (like shadow_argument_reporter) that sets that property.

eh, that would require deeper changes and its only used by this check

@GarboMuffin
Copy link
Member

it is better for this to be set declaratively on the block in getInfo() then the vm will forward it along

@yuri-kiss
Copy link
Member Author

it is better for this to be set declaratively on the block in getInfo() then the vm will forward it along

Fineee, I will do both 😔

@yuri-kiss yuri-kiss changed the title Allow adding custom shadow argument reporters Allow adding custom shadow argument reporters (SB part) Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants