-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ [@turf/intersect][@turf/difference][@turf/union] bump polygon-clipping to 0.15.3 #2085
Conversation
@twelch Thanks for the contribution |
Fair enough, you were involved with that PR after all 😄 Martinez 0.7 still has improvements that I require for my work, and maintain a fork of turf-intersect to get. Let me know if anything more is needed to approve. |
I see that the yarn lockfile changes that crept into this small PR are fairly substantial and possibly due to my running a newer (currently latest) yarn version |
I'm just now tuning in to the work that has gone into the v7 branch - #1432. [Edit] Okay I'm seeing other issues that relay the v7 branch is defunct. I guess I'll wait for word 😅 . fwiw, I'm interested in contributing more substantially it's just not clear how/where/who to plug in. This PR is a test in a way for me. |
I removed the lockfile changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for your contribution @twelch ! |
This PR bumps turf packages to the latest
polygon-clipping
0.15.3, which upgraded tomartinez-polygon-clipping
0.7.0 (mfogel/polygon-clipping#114) and has valuable improvements for features with holes (w8r/martinez#113).npm test
at the sub modules where changes have occurred.npm run lint
to ensure code style at the turf module level.