Basic rewrite of the package 2023 edition Part II: Location-scale variational families #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-Portal
requested review from
torfjelde and
yebai
and removed request for
torfjelde
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 81.15% 85.92% +4.77%
==========================================
Files 10 11 +1
Lines 138 199 +61
==========================================
+ Hits 112 171 +59
- Misses 26 28 +2 ☔ View full report in Codecov by Sentry. |
yebai
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks @Red-Portal -- it looks good overall. I have a few minor comments below.
test/interface/location_scale.jl
Outdated
Comment on lines
36
to
37
| z = rand(q) | ||
| @test eltype(z) == realtype |
There was a problem hiding this comment.
A bit redundant with above logpdf tests.
Suggested change
| z = rand(q) | |
| @test eltype(z) == realtype |
There was a problem hiding this comment.
@yebai Though without it, it seems codecov complanes that _logpdf is not covered. Should I still remove the tests fore _logpdf?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial pull request of #45.
(The original PR is now severely outdated.)
The content of Part II is as follows: