Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit SciMLBase verison #2143

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Limit SciMLBase verison #2143

merged 2 commits into from
Dec 14, 2023

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Dec 14, 2023

SciMLBase made some internal interface change (syms and paramsyms are removed) in v2.11. These changes have not been reflected in Optimization.jl.

For now, this PR limits the version compat of SciMLBase to 2.10.

Copy link
Contributor

Pull Request Test Coverage Report for Build 7206998394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 7199212186: 0.0%
Covered Lines: 0
Relevant Lines: 1384

💛 - Coveralls

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f13998) 0.00% compared to head (4785b0c) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2143   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1384    1384           
======================================
  Misses       1384    1384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunxd3 sunxd3 requested a review from yebai December 14, 2023 10:53
@yebai yebai merged commit 521f791 into master Dec 14, 2023
11 of 13 checks passed
@yebai yebai deleted the sunxd3-patch-1 branch December 14, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants