CompatHelper: bump compat for SciMLBase to 2, (keep existing compat) #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2023-12-15-00-25-45-358-01316652819
branch
from
f5398af to
2adc99f
Compare
Pull Request Test Coverage Report for Build 7259150907
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1396 1396
======================================
Misses 1396 1396 ☔ View full report in Codecov by Sentry. |
|
Fixed by #2144 |
|
Version limit for |
…45-358-01316652819
|
@yebai SciML team has updated |
|
Fails at here, couldn't replicate locally. |
…45-358-01316652819
yebai
deleted the
compathelper/new_version/2023-12-15-00-25-45-358-01316652819
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
SciMLBasepackage from1.37.1, < 2.11to1.37.1, < 2.11, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.