Modify version_check.yml to not create new PRs on PRs from forks #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
pysm/fix-version-check-forks
branch
from
5b866ca to
471dc44
Compare
penelopeysm
force-pushed
the
pysm/fix-version-check-forks
branch
from
471dc44 to
b74450b
Compare
|
Preview the changes: https://turinglang.org/docs/pr-previews/511 |
|
Looks good, thank you, @penelopeysm, feel free to merge! |
shravanngoswamii
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PR is made from a fork
their_fork/docswith branch nametheir_branch, the create-pr action in version_check.yml attempts to open a PR against thetheir_branchbranch in this repository, i.e.TuringLang/docs.This causes the action to fail because
their_branchdoesn't exist as a branch in this repo. See e.g. #509 and in particular this run https://github.com/TuringLang/docs/actions/runs/10505358369/job/29136841113This PR fixes this by detecting if the PR is being made from a fork. If so, don't attempt to open a PR.