Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Meta main #524 #530

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Solved Meta main #524 #530

merged 11 commits into from
Oct 10, 2024

Conversation

beingPro007
Copy link
Collaborator

solved #524

Added the meta variables in _quarto.yml
Screenshot 2024-10-06 165334

and used them here like
Screenshot 2024-10-06 165931

Kindly merge this Pull Request

@beingPro007
Copy link
Collaborator Author

@yebai Please review this and if correct then merge this to the master branch

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Preview the changes: https://turinglang.org/docs/pr-previews/530
Please avoid using the search feature and navigation bar in PR previews!

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @beingPro007, thanks for working on this 😄

I have a few suggestions for contributing to open source code.

  1. Make your commit messages more descriptive. In this case I don't know what 'Meta main 524' is. A better commit message would be Add Quarto variables. If you want to make reference to the GitHub issue, you can write a multiline commit message (note that the hashtag, like #524, is the usual way of referring to a GitHub issue or pull request):

    Add Quarto variables
    
    Closes #524
    

    In this case, the first line is shown to users and when they look more closely (either via git log or via the GitHub web interface) they can see the full message.

    Here's an old, but very good, explanation of what goes into a good commit message: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

  2. Most of the changes in this PR are removing trailing whitespace. That's great, but it is a separate matter from the Quarto variables, so would be even better if those were part of a separate commit. So you could have one commit that is just for the variables, and one commit that is just for whitespace. They could both still be part of this PR, but having atomic commits (i.e. one commit that does just one thing) makes it much easier to understand the changes and history of the repository.

  3. Use permalinks to refer to code, instead of screenshots. See https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet

    Permalinks let you click through to the actual code in the repository, and are also more accessible than screenshots (which can't be read with eg text-to-speech).

_quarto.yml Outdated Show resolved Hide resolved
_quarto.yml Outdated Show resolved Hide resolved
tutorials/08-multinomial-logistic-regression/index.qmd Outdated Show resolved Hide resolved
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us introduce a base URL meta variable to replace .. or ../.. usage across tutorials:

../{{<meta using-turing-autodiff>}}

becomes

 {{<meta doc-base-url>}}/{{<meta using-turing-autodiff>}}

@beingPro007
Copy link
Collaborator Author

@penelopeysm and @yebai I considered this thing as a feedback for this PR and will try to resolve it again and do the following changes as told. Thank you for considering me😁

@penelopeysm
Copy link
Member

No problem, feel free to ask if anything is unclear :)

- Added `<meta doc-base-url>` to replace `..` or `../..` usage across tutorials.
- As per feedback from @penelopeysm, added an anchor to the specific part of the docs for the tutorial.
- Included the `probability-interface` tutorial in the context.
- Ensured no unnecessary whitespace changes to keep the pull request clean and focused.
- Implemented all required Quarto meta variables, as suggested by @yebai.
- These changes include the addition of all necessary meta variables identified up to this point.
- Future adjustments can be made as needed to accommodate any further requirements.
@penelopeysm
Copy link
Member

@beingPro007 Did you plan to make any more changes?

If you're done editing, you can request a review at the top-right of the PR screen with the refresh button here:

Screenshot 2024-10-09 at 14 44 08

@beingPro007 beingPro007 requested a review from yebai October 9, 2024 14:12
@penelopeysm
Copy link
Member

Yup!

_quarto.yml Outdated Show resolved Hide resolved
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, although I didn't check whether the links actually work!

@penelopeysm
Copy link
Member

@yebai I was thinking about maybe introducing a link checker at some point in time to check that the hyperlinks all return 200 :)

@beingPro007
Copy link
Collaborator Author

beingPro007 commented Oct 9, 2024

@yebai I was thinking about maybe introducing a link checker at some point in time to check that the hyperlinks all return 200 :)

Yes, this is a great idea! If possible as it reduces the manual checking of the broken links, we can utilize an external link checker like linkinator or broken link checker in our CI pipelines. Here’s a quick example of how we could implement linkinator in a GitHub Action


on:
  push:
  pull_request:

jobs:
  linkChecker:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout repository
        uses: actions/checkout@v2

      - name: Install Node.js
        uses: actions/setup-node@v2
        with:
          node-version: '16'

      - name: Install linkinator
        run: npm install -g linkinator

      - name: Run linkinator
        run: linkinator . --recurse

This configuration checks all links in our project automatically on each push or pull request. Let me know your thoughts!

@penelopeysm
Copy link
Member

That's a matter for a separate issue/PR.

@penelopeysm penelopeysm merged commit 567181b into TuringLang:master Oct 10, 2024
4 checks passed
@penelopeysm
Copy link
Member

(I just did some minor cleanup to get things working nicely.)

Thanks for the contribution, @beingPro007!

@beingPro007 beingPro007 deleted the meta-main branch October 11, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants