Cap lint levels for rustc #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cap the lint levels to "warn". Some crate authors are anal about setting "deny(warnings)", which means that if we get a warning compiling this crate, the compile will fail. Override this by using the "--cap-lints" option. Just hardcode, as a first shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick hardcode capping lints to warn.
Some crate authors think they know best and set "deny(warnings)", which means
that if we get a warning compiling this crate, the compile will fail.
Annoying !
In a "normal" cargo compile, cargo knows when a crate is upstream and then sets "--cap-lints" on rustc.
However, how that would work for mkRustCrate, I have no idea...
Might be as simple as adding a "source = ..." line to Cargo.lock...
A better solution would, of course, be to let cargo add the "--cap-lints" options itself on upstream crates, instead of hard coding.