Addition of paletteSize
, while removing private field of Palette'
#184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I gather
_paletteSize
is an unnecessary field inPalette'
, since it can be deduced from the size of_paletteData
and the type of pixel, which is exactly the way that the newly addedpaletteSize
is implemented. Couple benefits that come from this change:Palette'
is now anewtype
aroundVector
, hence slight reduction to memory usage and overall improvement to performance_paletteSize
that is coupled to the actual data allows construction of incorrectPalette'
, which opens a possibility of a segfault when using images converted from such palettes bypalettedAsImage