Fix JPEG parsing regression #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n value. Fixes regression reported in Twinside#215 (comment) Also fix follow-up error that `parseFrames`, `parseFramesSemiLazy` and `parseToFirstFrameHeader` incorrectly tried to parse beyond the `JpgEndOfImage`. Jpg: Fix `parseToFirstFrameHeader`
…s failing. Also fix the test implementation.
nh2
force-pushed
the
jpeg-parsing-fixes-2
branch
from
c88dab7 to
c6dff55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the regression from #215 (comment).
I made a couple mistakes there.
I improved the equivalence test (which was not correct), and further confirmed it against the old implementation in my separate branch
jpeg-parsing-fixes-2-investigationwith commit 054d76b.I also want to point out (beyond issue #214) that the test suite as it is now is totally insufficient, because it does not catch even the most severe errors like JPEGs not parsing correctly at all. That makes it difficult to contribute performance fixes like #215 with confidence.