Define ObjSpaceViewDir in Fragment Shader #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
ObjSpaceViewDir()
Per Vertex from the Vertex Shader there is visible Warbling to Texture3D due to inaccuracies missed which are correct when calling the same method Per Fragment from the Fragment Shader.Either allow calling of this method from both Shader Programs or provide a separate implementation for each.
Standard Method in the Vertex Shader before edit
Self-Defined Method in the Fragment Shader after edit
This is what I used to fix it in my own volumetric shader, though I shouldn't have to write it again as such.
Pending an update with a correction to the Vertex Shader implementation of this method to remove the Warbling...