Fix getReflectionsFromSymbolId from returning undefined elements #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning [undefined] causes downstream TypeErrors.
Example:
```
TypeError: Cannot read properties of undefined (reading 'kindOf')
at ./node_modules/typedoc/dist/lib/models/types.js:688:25
at Array.find (<anonymous>)
at get reflection [as reflection]
```
nbilyk
force-pushed
the
fix-get-reflections-from-symbol
branch
from
9ff23fd to
2ea0eaf
Compare
|
These assertions are in place because it shouldn't be possible for ids in symbolToReflectionIdMap to be invalid. If they are, that's a bug elsewhere. This hides the problem, but it's still broken. |
|
Gerrit, I thought that might be the case, although this commit does avoid what I was hitting. I unfortunately don't have an isolated test case to provide, it happens when a library re-exports modules from another library that has type declarations. |
|
Could you point me to it anyways? I might have enough time this weekend to dive into it |
|
Closing, I updated to 25.12 and no longer have this issue. Thanks whomever fixed this for me :) |
|
Strange... nothing that I can remember should have changed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning [undefined] causes downstream TypeErrors.
Example: