Cb dev #10
Open
Cb dev #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New giraffe_gui. New pdf_report. Improvements to giraffe_qa
Minor changes plus requirments file
Minor changes to GUI and to work with main database.
This should solve issue of two curves with significantly different amplitudes fitting poorly.
Adding gantry and date to file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this is probably as finished as it needs to be to get remerged. There are some changes to pdd_module that will need reviewing. Also bortfeld_fit.py is hopefully a bit more modular and has a section at the bottom that will allow it to run on random files without needing to call giraffe_qa.py
At the moment giraffe_qa.py just does some printing but pretty soon we should add some database interaction. I think any database interaction though should come after the plotting so that there can be a user interaction to say "Yes the fit looks good" or "No it doesn't let's not upload that because there's a bug"
Also PTPR seems to work but I think it's extrapolating and assuming constant value beyond the limits of the data. Be good to know what you think? Also be worth chatting to find out how much we want to measure it anyway.