Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to implement an robust ratelimiting system. This is done now so we can focus on building the actual API next. Although this ratelimiter implementation does use
slowapi
, I think it will be fine for now. The only other library basically doesn't even work at all from the last time I checked. Although this library does block the event loop, hopefully it shouldn't accept the performance of the app.In addition, Redis is used here to synchronize the ratelimit cache. We could always use Redis to build an cache later on.
Types of changes
What types of changes does your code introduce to Kanae?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply