Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated doc strings #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: updated doc strings #101

wants to merge 3 commits into from

Conversation

charliekush
Copy link
Contributor

Issues addressed from #93

@charliekush charliekush requested a review from ntlhui October 18, 2024 16:22
@charliekush charliekush linked an issue Oct 18, 2024 that may be closed by this pull request
10 tasks
Comment on lines +116 to +117
* @details This integer represents the current position within
* the `dir_stack`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superfluous

* @brief Constructs a path from the current directory stack.
*
* @param is_dir If true, the path is a directory path.
* @return const char* The constructed file or directory path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return should not include the type information

* @brief Constructs a path from the current directory stack.
*
* @param is_dir If true, the path is a directory path.
* @return const char* The constructed file or directory path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add that the returned buffer will only be valid until the next invocation of buildPath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: File CLI
2 participants