Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds stereo-diving-rig #115

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

ntlhui
Copy link
Contributor

@ntlhui ntlhui commented May 24, 2024

No description provided.

@ntlhui ntlhui linked an issue May 24, 2024 that may be closed by this pull request
@ntlhui ntlhui requested a review from Sean1572 May 24, 2024 17:39
@ntlhui ntlhui enabled auto-merge May 24, 2024 17:40
Copy link
Contributor

@Sean1572 Sean1572 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not have a reference to open it in old_projects.md

Suggested change:

 - project_name: "Stereo Diving Rig"
   photo: "assets/nautical_archaeology/2014-06-26_stereo_rig.jpg"
   text: "a modular, diver-propelled underwater data collection platform"
   link: "stereo-diving-rig"

@ntlhui
Copy link
Contributor Author

ntlhui commented May 25, 2024

This does not have a reference to open it in old_projects.md

Suggested change:

 - project_name: "Stereo Diving Rig"
   photo: "assets/nautical_archaeology/2014-06-26_stereo_rig.jpg"
   text: "a modular, diver-propelled underwater data collection platform"
   link: "stereo-diving-rig"

No, since it is not done this way on the current website

@Sean1572 Sean1572 self-requested a review May 25, 2024 23:58
@ntlhui ntlhui merged commit 7ca9482 into main May 25, 2024
3 checks passed
@ntlhui ntlhui deleted the pages/113-stereo-diving-rig-missing branch May 25, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/stereo-diving-rig missing
2 participants