Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rails 6.1 defaults #2452

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Use Rails 6.1 defaults #2452

merged 1 commit into from
Dec 4, 2024

Conversation

mec
Copy link
Collaborator

@mec mec commented Dec 4, 2024

We've been running Rails 6.1 for a while now and inline with the upgrade
documentation, we should now be using the 6.1 defaults:

https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#configure-framework-defaults

Rather than change each individual setting, we've gone all in and taken
confidence from our extensive test suite that everything is good.

This clears a path for the Rails 6 to 7 upgrade.

We've been running Rails 6.1 for a while now and inline with the upgrade
documentation, we should now be using the 6.1 defaults:

https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#configure-framework-defaults

Rather than change each individual setting, we've gone all in and taken
confidence from our extensive test suite that everything is good.

This clears a path for the Rails 6 to 7 upgrade.
Copy link
Contributor

@benshimmin benshimmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mec mec merged commit 0c5d52e into develop Dec 4, 2024
5 checks passed
@mec mec deleted the chore/use-rails-6.1-defaults branch December 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants