Allow users to have additional organisations #2454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benshimmin
force-pushed
the
feature/data-migration-to-allow-users-to-have-additional-organisations
branch
3 times, most recently
from
152c3b4 to
aa7df87
Compare
This creates a `has_and_belongs_to_many` join table relationship between organisations and users, allowing a user to belong to `additional_organisations` and paves the way to allowing a user to set their `organisation` to be a `Current.user_organisation` and thus view data for that organisation instead of their own "real" organisation. This should change nothing about the existing functionality of the site and will be entirely invisible to end users. (The next phase will include front-end changes which *will* allow selected users to switch their current organisation.) Helper methods on the `User` model to navigate this relationship include `primary_organisation` (to retrieve the user's actual `organisation`, which is necessarily overwritten), `all_organisations` (the union of `primary_organisation` and `additional_organisations`) and `additional_organisations?` (to determine whether a user has a non-zero number of `additional_organisations`).
benshimmin
force-pushed
the
feature/data-migration-to-allow-users-to-have-additional-organisations
branch
from
aa7df87 to
12a2413
Compare
benshimmin
deleted the
feature/data-migration-to-allow-users-to-have-additional-organisations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
has_and_belongs_to_manyjoin table relationship between organisations and users, allowing a user to belong toadditional_organisationsand paves the way to allowing a user to set theirorganisationto be aCurrent.organisationand thus view data for that organisation instead of their own "real" organisation.This should change nothing about the existing functionality of the site and will be entirely invisible to end users. (The next phase will include front-end changes which will allow selected users to switch their current organisation.)
Helper methods on the
Usermodel to navigate this relationship includeprimary_organisation(to retrieve the user's actualorganisation, which is necessarily overwritten),all_organisations(the union ofprimary_organisationandadditional_organisations) andadditional_organisations?(to determine whether a user has a non-zero number ofadditional_organisations).Next steps
CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.