Hoff 113- added Hof skeleton project

[TemitopeAyokuHO]

What?

HOFF-113. create HOF skeleton

Why?

To create a simple and unique template for HOF forms

How?

• add apps folder and other necessary files

common
hof-project
test

• add entry page for the app as start.html
• modify hof.settings.json file to set the route for entry url, specifying the project name , and session id
• add a readme file for first time users
• modify the package.json file to add package dependencies, project name and versions and repository url

Testing?

Tested locally

Screenshots (optional)

Anything Else? (optional)

[sulthan-ahmed]

In terms of your PR, it's good you linked the JIRA ticket.

I would still give a worded What to save the reviewer to go through the ticket. You can just say create HOF skeleton

[TemitopeAyokuHO]

In terms of your PR, it's good you linked the JIRA ticket.

I would still give a worded What to save the reviewer to go through the ticket. You can just say create HOF skeleton

The Jira ticket is linked to the PR in What section

[sulthan-ahmed]

Great you've updated it. The link is great it's just it's good to always make it easy for a reviewer to know what the PR is. It's also about people in the future that look back at this PR. They might not be able to access the link in the future

[sulthan-ahmed]

I would highly recommend reading about how to do documentation on github https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/quickstart-for-writing-on-github

Whenever you put in codeblocks, the common practice is to use backticks

[Rhodine-orleans-lindsay]

I would change

'/confirmation': {
      backLink: false
 }

to

'/confirmation': {
     clearSession: true
}

[Rhodine-orleans-lindsay]

I have unresolved this as I can't see the change - has it been pushed?

[Rhodine-orleans-lindsay]

it should say clearSession: true

[TemitopeAyokuHO]

Yes push already i have no idea why the changes not coming on

[sulthan-ahmed]

I agree with @Rhodine-orleans-lindsay the less code/files/modules the better. This also includes content. The main aim of this repo is to build new projects from. Even the readme imho should just tell you how to install and run the app

[Rhodine-orleans-lindsay]

There is a .DS_Store file in the assets folder that should be ignored by git so you'll need to delete that before you push again

[TemitopeAyokuHO]

There is a .DS_Store file in the assets folder that should be ignored by git so you'll need to delete that before you push again

.DS_Store file not found

[sulthan-ahmed]

👍

[TemitopeAyokuHO]

@Rhodine-orleans-lindsay and @sulthan-ahmed should i squash all the commit messages ?

[sulthan-ahmed]

You can squash it once it's approved
please follow the chris beams approach of git messages when you do squash it

[sulthan-ahmed]

Here is an example of how @adityababumallisettiHO did a really great git commit message https://github.com/UKHomeOfficeForms/hof-services-config/pull/189/commits/7a111450b6cd90ab558de4d1f4466f42b224b825