Skip to content

Commit

Permalink
HOFF-648: fix typo causing spacing issues
Browse files Browse the repository at this point in the history
- moved hint and error message out of select label tag to fix typo found when updating NRM to latest hof version where hint and error message were incorrectly in select label tag causing spacing issues
  • Loading branch information
Rhodine-orleans-lindsay committed May 22, 2024
1 parent cd4be04 commit 4d078a8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions frontend/template-mixins/partials/forms/select.html
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<div id="{{id}}-group" class="{{#compound}} form-group-compound{{/compound}}{{#formGroupClassName}} {{formGroupClassName}}{{/formGroupClassName}}{{#error}} govuk-form-group--error{{/error}}">
{{#isPageHeading}}<h1 class="govuk-label-wrapper">{{/isPageHeading}}<label for="{{id}}" class="{{labelClassName}}{{#isPageHeading}}govuk-label--l{{/isPageHeading}}">
{{{label}}}
{{#hint}}<span {{$hintId}}id="{{hintId}}" {{/hintId}}class="govuk-hint">{{hint}}</span>{{/hint}}
{{#error}}
<p class="govuk-error-message">
<span class="govuk-visually-hidden">Error:</span> {{error.message}}
</p>
{{/error}}
</label>
{{#isPageHeading}}</h1>{{/isPageHeading}}
{{#hint}}<div {{$hintId}}id="{{hintId}}" {{/hintId}}class="govuk-hint">{{hint}}</div>{{/hint}}
{{#error}}
<p class="govuk-error-message">
<span class="govuk-visually-hidden">Error:</span> {{error.message}}
</p>
{{/error}}
<select id="{{id}}" class="govuk-select{{#className}} {{className}}{{/className}}{{#error}} govuk-select--error{{/error}}" name="{{id}}" aria-required="{{required}}">
{{#options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{label}}</option>
Expand Down

0 comments on commit 4d078a8

Please sign in to comment.