-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ONNX models from HuggingFace #393
base: model-api-v3
Are you sure you want to change the base?
Conversation
docker-compose.ytt.min.yaml
Outdated
@@ -207,6 +207,218 @@ services: | |||
- rabbit | |||
- redis | |||
|
|||
|
|||
onnx_bert_worker: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these services really be part of the "minimal" version of square?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We copied the dependencies from the tasb_worker. When I try to remove rabbit or redis from any of our services, I get the following errors during requests:
- amqp.exceptions.AccessRefused: (0, 0): (403) ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.
- redis.exceptions.ResponseError: WRONGPASS invalid username-password pair or user is disabled.
I think that 'minimal" in this case refers to the UI not being included
- Maybe we should rename the file to "docker-compose.ytt.no-frontend.yaml"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, services like Rabbit, Redis, Mongo etc they are dependencies of other core services, so no need to remove them.
However, I was more talking about the additional models that are added here. IMHO, this file should just deploy a single model and single datastore. This is basically just a demo of the each component. Therefore, I think we do not need additional models in this file. But please pitch in @Rachneet or @kwang2049 if you have a different opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rachneet do you want these model services to be added to the docker-compose.ytt.yaml or should they be deployed dynamically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be deployed dynamically. For testing purposes only, these services can be added to docker-compose.models.yaml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work and PR! Just a couple of small changes and clarifications from my side. However, I have just looked superficially. @Rachneet can give more feedback.
What does this PR do?
Changes onnx inference model's source from local file to HuggingFace repository
We updated the existing onnx tests to use models from HF and added tests for quantized qa
We provide model configurations for extractive, categorical, multiple-choice and abstractive QA
Minor additional changes:
Who can review?
@HaritzPuerto
@Rachneet