Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the local-minimal version runnable again #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwang2049
Copy link
Collaborator

@kwang2049 kwang2049 commented Feb 13, 2023

What does this PR do?

It seems that some new lines have been added and the current local minimal version cannot run successfully. This PR fixes the issue.

Changes:

  • Traefik port 8080->8081: 8080 is very likely to be in use already;
  • Commented out BERT-ONNX-worker: Some file is missing. One can add it back when the file is provided;
  • Corrected comment format in the yaml file: # -> #!;
  • Generate .env file for model manager.

Before submitting / marking as 'ready to review'

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Feel free to tag members/contributors who may be interested in your PR.

@kwang2049 kwang2049 changed the title Make the local-minimal version runnable Make the local-minimal version runnable again Feb 13, 2023
@kwang2049
Copy link
Collaborator Author

@Rachneet a file is missing:

dockerfile: ./dockerfiles/onnx/Dockerfile

@kwang2049 kwang2049 requested a review from timbmg February 13, 2023 12:27
@kwang2049
Copy link
Collaborator Author

Does anybody know how to add CI tests for this minimal version? @timbmg @Rachneet We can then make it easier for maintaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant