Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3주차/jerry] 워크북 제출합니다. #44

Merged
merged 4 commits into from
Nov 3, 2024
Merged

[3주차/jerry] 워크북 제출합니다. #44

merged 4 commits into from
Nov 3, 2024

Conversation

gaaahee
Copy link
Contributor

@gaaahee gaaahee commented Oct 10, 2024 •
edited
Loading

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?(중요)
  • 적절한 라벨을 설정하였나요?
  • 파트장에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?(매우 중요!)

📌 주안점

@gaaahee gaaahee requested a review from lsy1307 October 10, 2024 04:15
@gaaahee gaaahee self-assigned this Oct 10, 2024
@gaaahee gaaahee linked an issue Oct 10, 2024 that may be closed by this pull request
Chapter03_Styled-Components, React Router, API 통신 #38
Open
@gaaahee gaaahee changed the title [3주차/jerry] 키워드 제출합니다. [3주차/jerry] 워크북 제출합니다. Oct 13, 2024
@gaaahee
Copy link
Contributor Author

gaaahee commented Oct 13, 2024

3주차 미션을 완성하지 못했습니다ㅠㅠ
일단 구현한 부분까지 푸쉬했습니다 죄송합니다..

lsy1307
lsy1307 reviewed Oct 14, 2024
View reviewed changes
Copy link

@lsy1307 lsy1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알겠습니다! 완료하시면 확인하고 approve 해드릴게요!

@gaaahee
Copy link
Contributor Author

gaaahee commented Nov 1, 2024

3주차 미션 완료해서 푸쉬했습니다

lsy1307
lsy1307 approved these changes Nov 3, 2024
View reviewed changes
Copy link

@lsy1307 lsy1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 제리!

@gaaahee gaaahee merged commit ae1c5a3 into UMC-Inha:jerry/main Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsy1307 lsy1307 lsy1307 approved these changes

Assignees

@gaaahee gaaahee

Labels
Chapter03 Keyword Mission
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chapter03_Styled-Components, React Router, API 통신
2 participants
@gaaahee @lsy1307