New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Structure Analysis #222

Merged

l-kent merged 39 commits into main from points-to-analysis-alternate-merge

Oct 14, 2024

Contributor

sadrabt commented Jul 1, 2024 •

edited

Loading

implement DSA with union find
implement points-to visualiser functionality
Document tests
extend DSAUnionFindSolver from the UnionFindSolver
replace tuples with case classes
single instance of stack symbolic access for each variable violated by indirect_call and malloc_with_local3
bu(proc) in DSA throws no such elemenet exception for tests correct/indirect_call/clang_O2:GTIRB and correct/malloc_with_local3/clang_O2:GTIRB
storeExitJump(exitToEntry(exit), d1, d2) throws cast error for correct/syscall/gcc_O2:GTIRB and correct/syscall/clang_O2:GTIRB
resolve merge conflicts

includes symbolic access analysis and a reaching definitions analysis that works slightly differently from the one already implemented. (registers changed by a procedure call are defined by the call instruction)

sadrabt requested a review from l-kent

July 1, 2024 03:17

Contributor

l-kent commented Jul 1, 2024

I'm a bit confused by the commit history here - some of Yousif's commits that are not ready to merge in yet have been included, but then later reverted? Is there a neater way to do things than that?

l-kent reviewed

View reviewed changes

src/main/scala/translating/ReadELFLoader.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/SymbolicAccessAnalysis.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/solvers/IDESolver.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/util/RunUtils.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/test/scala/RegionBuilderTests.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/InterprocSteensgaardAnalysis.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/Local.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/Local.scala Outdated Show resolved Hide resolved

sadrabt force-pushed the points-to-analysis-alternate-merge branch from 90eec8e to 5cda0e9 Compare

July 1, 2024 05:30

Contributor

l-kent commented Jul 7, 2024

It'll take some time to get across all the details of this, so detailed comments would really help to make it easier to understand.

One thing that makes the code more difficult to follow at the moment is the widespread use of tuples - is it possible that replacing those with case classes would make sense?

sadrabt force-pushed the points-to-analysis-alternate-merge branch from fbcb303 to fe5b3e7 Compare

July 8, 2024 04:52

sadrabt added 12 commits

July 8, 2024 14:52


          graph utilities

af21c7d


          added stack object mapping

02eff56


          fixed pointer arithmetic with offset calculations

24e22ad


          tests


          added call sites

2b8b563


          bu phase

24ecede


          td phase

fbee14c


          handling relocations

d4f97f3


          IL changes

fccfa94


          fixes

c2f5a4b


          changed slice tuples to case class

75a3bfb


          separated function entries

f600c66

sadrabt force-pushed the points-to-analysis-alternate-merge branch from fe5b3e7 to f600c66 Compare

July 8, 2024 04:53

ailrst reviewed

View reviewed changes

src/main/scala/analysis/SymbolicAccessAnalysis.scala Outdated Show resolved Hide resolved


          added bv to signed integer

3526de8

l-kent reviewed

View reviewed changes

src/main/scala/analysis/Local.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/BitVectorEval.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/DSAUtility.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/DSAUtility.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/DSAUtility.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/solvers/DSAUnionFindSolver.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/DSAUtility.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/DSAUtility.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/SymbolicAccessAnalysis.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/SymbolicAccessAnalysis.scala Outdated Show resolved Hide resolved

l-kent reviewed

View reviewed changes

src/main/scala/analysis/SymbolicAccessAnalysis.scala Outdated Show resolved Hide resolved

sadrabt added 4 commits

September 23, 2024 12:22


          fixes

65c672a


          fixes

e6ee680


          fixes


          fixes

b4fe131

l-kent reviewed

View reviewed changes

src/main/scala/analysis/solvers/DSAUnionFindSolver.scala Outdated Show resolved Hide resolved

sadrabt added 2 commits

September 30, 2024 11:12


          stopped propagating stack SAA facts through direct calls

832937f

fix

e962460

sadrabt mentioned this pull request

DSA overlapping accesses #254

Closed

sadrabt and others added 11 commits

September 30, 2024 11:51


          fixes

83033a7


          example that causes assertions to fail

8caf294


          removed the unambiguous stack assumption

9bc70df


          Merge branch 'main' into points-to-analysis-alternate-merge

7c49adb

# Conflicts:
#	src/main/scala/analysis/solvers/IDESolver.scala
#	src/main/scala/translating/ReadELFLoader.scala
#	src/main/scala/util/RunUtils.scala
#	src/test/scala/IndirectCallsTests.scala
#	src/test/scala/IrreducibleLoop.scala
#	src/test/scala/LiveVarsAnalysisTests.scala
#	src/test/scala/PointsToTest.scala
#	src/test/scala/ir/InterpreterTests.scala


          fix IDESolver issues with empty procedures

69792b7


          general cleanup of DSA, particularly around overuse of tuple accesses…

4592fd3

… which are difficult to follow at a glance


          deprecate DSA test that used removed example, update DSA tests to use…

6e25419

… newer jumptable2 example, DSA test cleanup


          put DSA in its own package, rename classes for clarity, put DSG/Graph…

c0cf064

… in its own file since it's so big


          remove unnecessary use of options in StaticAnalysisContext for DSA re…

01b6c75

…sults


          more cleanup

b4c965f


          fix spelling

1c82a09

l-kent merged commit bb9163c into main

2 checks passed

Contributor

l-kent commented Oct 14, 2024

I've merged this and from my testing it seemed to be working fine, but please create issues for any problems that occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet