frontend fixes #251
Merged
frontend fixes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailrst
force-pushed
the
frontend-fixes
branch
from
d3b718a to
d9296f3
Compare
l-kent
reviewed
Sep 23, 2024
l-kent
reviewed
Sep 23, 2024
l-kent
reviewed
Sep 23, 2024
Comment on lines
+224
to
+230
| val dupProcNames = (ctx.program.procedures.groupBy(_.name).filter((n,p) => p.size > 1)).toList.flatMap(_._2) | ||
|
|
||
| var dupCounter = 0 | ||
| for (p <- dupProcNames) { | ||
| dupCounter += 1 | ||
| p.name = p.name + "$" + p.address.map(_.toString).getOrElse(dupCounter.toString) | ||
| } |
There was a problem hiding this comment.
This is good to have but may potentially cause problems elsewhere because there are some things (like indirect call resolution) that rely on the names of procedures in a somewhat fragile way. That is something that I want to fix in the indirect call resolution though.
There was a problem hiding this comment.
Yes its not correct to rely on names it should go through symbol table address -> basil procedure address, we should probably be clear about what the correct unique procedure identifier is in the IR though.
l-kent
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static) which have the same name but different addresses in the boogie output