Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory regions in Boogie using Data Structure Analysis #279

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

l-kent
Copy link
Contributor

@l-kent l-kent commented Nov 28, 2024

Implements #249

  • Adds a --memory-regions dsa option to insert regions based on the Data Structure Analysis results into the Boogie output
  • The existing version of memory region insertion can now be used by using --memory-regions mra
  • Fixes issue with invalid characters appearing in DSA .dot file output
  • External functions/objects listed in the symbol table are now handled correctly in the DSA, with the pointers being correctly treated as having size 8, renamed to indicate that they are pointing to the external function, and they now point to a new ExternalLocation which represents the abstract external function or object
  • Adds DSAMemoryRegionSystemTestsBAP and DSAMemoryRegionSystemTestsGTIRB test suites which run all SystemTests with the --memory-regions dsa option set

The DSA-based memory regions are currently able to handle all existing test cases successfully, though it likely does not handle anything involving overlapping accesses successfully yet since the DSA implementation there is not yet finished. It tracks the memory regions by creating a new Map, accessIndexToSlice, which maps from MemoryLoads and MemoryStores to Slices representing the indices of the accesses. This mapping is used as the basis for regions, with distinct cells representing distinct memory regions.

@l-kent l-kent requested a review from sadrabt November 28, 2024 03:32
}

override def getMergedRegion(address: BigInt, size: Int): Option[MergedRegionDSA] = {
val dsg = DSATopDown(program.mainProcedure)
Copy link
Contributor

@sadrabt sadrabt Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is size necessary? i don't think it is used by DSA MRA region injector? I think it also makes sense to check if the size is covered by the cell. But I assume this wouldn't hold for examples with globals with disjoint fields (cells) because the size passed as a parameter is the whole global region's size. However, maybe this is not necessary until we have better field-sensitivity implemented

@sadrabt
Copy link
Contributor

sadrabt commented Dec 2, 2024

The rest looks good to me

@l-kent l-kent merged commit 686ee8e into main Dec 3, 2024
2 checks passed
@sadrabt
Copy link
Contributor

sadrabt commented Dec 3, 2024

DSA-Regions extra Constraints #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants